Indicators for multiple instruments

Hi - an easy way to tell your algorithm to warm up is to set self.SetWarmup( xx ) in the Initialize function where xx is the number of bars you need for a warmup. In your case, you'll need not only to warm up the indicators but also populate the rolling windows.

Thanks for the answer Douglas Stridsberg ! 

However i do have a fe followup problems. Since i hae and basket of pairs that I am trading, if i move the indicators to initialize, and use the warmup function, would that warm it up for one pair or all pairs ? 
I did put the indicators into dictionaries earlyer and used the for loop in initilaize, but that just kept on giving the same output value ( so i failed to uppdat it).

I have been experimenting with rolling windows, and i have used it for one pair, but i seam to loose my self while doing multiple pairs. 

I made an attemt with my understanding of this situation with a rolling window, but i get an error. I am not using the initialize, as i need it created for every symbol. 

My understanding of SetWarmup is that it simply gets and pushes x number of datapoints for each of the subscribed symbols into whatever registered consolidators you have.

In order to get faster help here, could you a) give us the error you're receiving and b) shorten your code example to only the minimum things required to produce this error? I.e. remove all the comments and superfluous functionality, focusing only on the required pieces of code to produce the error. This way we can help you much faster. Right now your code is quite long and it would probably take quite a bit of time for someone to narrow down the issue.

Here is an link to the example that I am inspiered from, but I do not understand the sma part of it. 
https://github.com/QuantConnect/Lean/blob/master/Algorithm.Python/MultipleSymbolConsolidationAlgorithm.py

I have tried to clean up the code a bit to make it easyer to read, but quant connect is not uppdating my backtest so i cant attach it right now 

What the program does: 

It goes through the forex pairs, and is able to take trades with sl and tp in all of them. 

The problem is that it cant make use of indicators as part of the signals, since i am not able to figure out where to intitilize and call the indicators from. 

The error is : 

Runtime Error: ArgumentOutOfRangeException : Must be between 0 and -1
Parameter name: i
Actual value was 0.
at QuantConnect.Indicators.RollingWindow`1[T].get_Item (System.Int32 i) [0x0004c] in <23543ce0cd384e128799a1ad1753a505>:0
at (wrapper managed-to-native) System.Reflection.MonoMethod.InternalInvoke(System.Reflection.MonoMethod,object,object[],System.Exception&)
at System.Reflection.MonoMethod.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00032] in <b0e1ad7573a24fd5a9f2af9595e677e7>:0
at OnData in main.py:line 126
ArgumentOutOfRangeException : Must be between 0 and -1
Parameter name: i
Actual value was 0.
at QuantConnect.Indicators.RollingWindow`1[T].get_Item (System.Int32 i) [0x0004c] in <23543ce0cd384e128799a1ad1753a505>:0
at (wrapper managed-to-native) System.Reflection.MonoMethod.InternalInvoke(System.Reflection.MonoMethod,object,object[],System.Exception&)
at System.Reflection.MonoMethod.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00032] in <b0e1ad7573a24fd5a9f2af9595e677e7>:0 (Open Stacktrace)

Tells me that i am feeding it somthing wrong and not managing to make the indicators work. 

Hi Christian, your error suggests you're trying to use a RollingWindow before it's ready (i.e. fully populated). Please, each time you intend to use the window, check whether self.<window name here>.IsReady is true. If it's false, you should wait another loop before trying to use it.

Can you go through your rolling windows, apply the above check and re-try the backtest? If you still have issues, you can use the Insert Code Snippet to attach code (second button from the right, just above the text editor).

It never gets ready, so i think the main problem is that I am not setting the window correctly. 

I have googled for examples, but the example i linked to is the only example of multiple instruments and an indicator that I can find. 

This is from initialize function, and i think i somhow must set the indicators there. with a rolling window, but how am i able to set one set of indicators for each pair?

Hey,

Three things:

1. You haven't attached the complete code, so it's hard to see what might be missing.
2. You can't access [-1] of your rolling window - this entry does not exist. Your rolling window will contain entries from 0 to 19 (20-1).
3. OnData() is called every time you get new data. Right now, on line #9, you're making a new rolling window every time there's new data. That's not what you want - you want to .Add( data here ) on every OnData() call. The creation of the rolling window should only happen once (it's best to do this in Initialize()).

hey, posting the full code here, 

I will try to rework what you said in point 3 into it. 

It runns now, but the only reason for that is that i have commentet out the "and trend_sma == 1 :" in line 128. 

Also it never reaches the amount of candles to run the indicator. 

Ref poit 3: the reason i did it like this was that i thought that since i iterate through the symbols in the basket each time, i would need to create a new rolling windo for each instrument each time I went throug. 
But in the example link i posted from gitHub i can see that they solved it in another way, but i do not understand the prosess behind it, and have not bean able to recreate it. 

Also thanks for helping me and looking at this !! 

Hey, there's quite a lot going on in your code, I want to point out a few things:

• = RollingWindow[xxx](xxx) creates a new rolling window. This should be done only once per symbol. Again, in the code you sent, you're creating a new rolling window every time you get new data - this means it will always be empty!
• Typically, one window should only contain information for one symbol. I don't know why you've done self.quoteBarWindow = RollingWindow[QuoteBar](20) but in your example that window will be hard to use because you have 5 symbols. I can't see that you're ever using self.quoteBarWindow, so I'm guessing that line doesn't need to be in your example. It's always a good idea to clean and cut out lines that don't do anything, it makes it easier to read your own code.
• As with rolling windows, indicators should be created once per symbol. In your example, you're creating new indicators (and overwriting the old ones) every time there is new data. That's not the right way to do it.
• OnData() runs every time you get new data. Initialize() runs once.

Thanks for pointing it out, I have bean reworking it, and it seam to be more logical now. 

Indicator works, and the rolling window works, so thanks a lot for your pointers. 

However It only gives the values for GBPUSD, so it seems to skip or just write ower EURUSD. 

Are you able to spot something obvious that is wrong ? 

As you can see I walked away from the class with a rolling window and are now using the normal update function with a rolling window. 

Here you have only two rolling windows - self.smaWin_f and self.smaWin_s - but you're trying to stuff the data from two symbols into these. You will need two rolling windows per symbol to achieve what you're trying to do. I suspect instead of self.smaWin_f you meant symbolData.smaWin_f.

Also, with this setup you're going to need two update handlers per symbol, which is not pretty. I'm not a Python expert but you should look to use lambda or inline functions as binds to the .Updated event rather than have separate functions outside of the loop. In C#, for example, it could look like this:

Thanks a lot for all your pointers, and it have given me a direction to keep on working with it. 


I did soe more web searches through the weekend, and it seems that creating a class, and using the rolling window throug that is the way to go about it if one would like to avoid all the functions.

But i need to keep on looking onto that. 

Hi Christian,

Multiple Symbol Consolidation Algorithm is a great source for you to look at. The essential idea is we create a SymbolData class which defines, initialize and/or update all fields for each symbol and maintain a mapping (self.Data) which maps from symbol to its corresponding SymbolData class. All those parameters and methods regarding a single symbol should go into that class.

Ideally your way of defining every parameter as a dictionary would work, but it is very redundant and not recommend. In your most recent work, self.smaWin_f and self.smaWin_s are rewritten each time the indicators of any symbol are updated.

Here is my attempt to rewrite your strategy with SymbolData class idea. I passed in the QCAlgorithm instance to the SymbolData in the initializer. When we need to call a method/field from QCAlgorithm, we could simply call self.algorithm.doSomething.

Hope it helps.

Wow, Thanks !! 

That is exactly what I have been looking for. 

cant say that i understand it all yet, but I will play around with it, 

once again, thanks for sharing: