Custom Indicator

I've been stuck on not understanding what's wrong for hours now. I'm just getting a whole lot of blank. The MACD values i'm getting back are wrong too. :(

did you find the problem?

you could do this like in the example and update values manualy

in your own method:

oh and also if you think that you did already rigth try to take a different default moving average....

last line

Can you use the MACD indicator instead?

I am new here, I am trying to convert the script like John, here is my script;  

fastperiod = input(12,title="fastperiod",type=integer,minval=1,maxval=500)
slowperiod = input(26,title="slowperiod",type=integer,minval=1,maxval=500)
signalperiod = input(9,title="signalperiod",type=integer,minval=1,maxval=500)
fastMA = ema(close, fastperiod)
slowMA = ema(close, slowperiod)
macd = fastMA - slowMA
signal = ema(macd, signalperiod)
macdAS = macd - signal

Thanks for any help in advance

Hi Hasan.

Welcome to QuantConnect. I've attached a backtest where I've implemented a simple version of a MACD strategy.

The algorithm goes long SPY when the MACD-Histogram value is positive and shorts SPY when the value is negative.

Hi Hasan,

I would recommend getting comfortable with QuantConnect's API using Bootcamp and some Tutorials. Converting scripts like these will become easier. 

For example QuantConnect provides over 100 technical indicators in the form of an object. You can even have indicators of indicators. Here are some of the indicator objects that can be used for this:

self.ema = self.EMA("IBM", 14, Resolution.Daily)

# define our daily macd(12,26) with a 9 day signal
self.__macd = self.MACD("SPY", 12, 26, 9, MovingAverageType.Exponential, Resolution.Daily)

 And here is a fully implemented MACD strategy:

Hi to all,

Thank you all for the answers. I am doing some explorations on framework nowadays.

Hi Halldor,

Thank you for sharing your code

Would it be possible to add green color for the histogram bars above 0 and red color for the histogram bars below 0?

import numpy as np
from System.Drawing import Color
from decimal import *

class macdExample(QCAlgorithm):

    def Initialize(self):
        self.SetStartDate(2018, 6, 1)
        self.SetEndDate(2019, 2, 1)
        
        self.SetCash(10000)
        
        self.spy = self.AddEquity("SPY", Resolution.Daily)
        self.macd = self.MACD("SPY", 12,26,9,Resolution.Daily)
        
        # Establish Trade Plot
        IndicatorPlot = Chart("Trade Plot")
        IndicatorPlot.AddSeries(Series("macd", SeriesType.Line,"", Color.Red))
        IndicatorPlot.AddSeries(Series("signal", SeriesType.Line,"", Color.Blue))
        IndicatorPlot.AddSeries(Series("histogram", SeriesType.Bar,"", Color.Black))
        IndicatorPlot.AddSeries(Series("Long", SeriesType.Scatter,"", Color.Green))
        IndicatorPlot.AddSeries(Series("Short", SeriesType.Scatter,"", Color.Red))
        self.AddChart(IndicatorPlot)
        
    def OnData(self,data):
        if not (data.ContainsKey("SPY")): return
        if not self.macd.IsReady: return
    
        # Indicator values
        hist=self.macd.Histogram.Current.Value
        
        # If histogram is positive, then go long SPY
        if hist>=0:
            if not self.Portfolio["SPY"].Quantity > 0:
                self.SetHoldings("SPY",1)
                self.Plot("Trade Plot", "Long", 0)
                
        # If histogram is negative, then go short SPY
        elif hist < 0:
            if not self.Portfolio["SPY"].Quantity < 0:
                self.SetHoldings("SPY",-1)
                self.Plot("Trade Plot", "Short", 0)
    
    def OnEndOfDay(self):
        # Add values to plot
        if not self.macd.IsReady: return

        self.Plot("Trade Plot", "macd", self.macd.Current.Value)
        self.Plot("Trade Plot", "signal", self.macd.Signal.Current.Value)
        self.Plot("Trade Plot", "histogram", self.macd.Histogram.Current.Value)

Hi Jon

Sorry, it is not possible due to the limitation of our IDE's charting package. A workaround could be using 2 bar series for the same MACD indicator histogram. One with value equals 0 if histogram value > 0, while the other one equals 0 if histogram value < 0.

Best
Louis